短信代码优化

src/main/java/com/caimei365/tools/controller/SmsApi.java

@@ -37,9 +37,9 @@ public class SmsApi {
     @ApiOperation("发送消息")
     @PostMapping("/sms/send")
     public ResponseJson<String> sendSms(SmsDto smsDto){
-        log.info(smsDto.toString());
         String result = SmsUtil.sendSms(smsDto.getType(), smsDto.getMobile(), smsDto.getContent());
         JSONObject json = (JSONObject) JSONObject.parse(result);
+        log.info("发送结果：" + result + "，短信内容：" + smsDto.toString());
         if (null != json && json.getInteger("code") == 0) {
             return ResponseJson.success(0, "发送成功",null);
         } else {

src/main/java/com/caimei365/tools/service/impl/RocketMqServiceImpl.java

@@ -75,6 +75,7 @@ public class RocketMqServiceImpl implements RocketMqService {
                     returnResult = rocketMQTemplate.syncSend(destination, message);
                 }
             }
+            log.info(returnResult.toString());
         } else {
             // 异步消息
             if (isDelay) {
@@ -88,6 +89,7 @@ public class RocketMqServiceImpl implements RocketMqService {
                     @Override
                     public void onException(Throwable throwable) {
                         //可以处理相应的业务
+                        log.info("异步消息发送失败:{}", JSON.toJSONString(throwable));
                     }
                 }, timeout, messageDto.getDelay());
             } else {
@@ -102,6 +104,7 @@ public class RocketMqServiceImpl implements RocketMqService {
                         @Override
                         public void onException(Throwable throwable) {
                             //可以处理相应的业务
+                            log.info("异步消息发送失败:{}", JSON.toJSONString(throwable));
                         }
                     });
                 } else {
@@ -114,6 +117,7 @@ public class RocketMqServiceImpl implements RocketMqService {
                         @Override
                         public void onException(Throwable throwable) {
                             //可以处理相应的业务
+                            log.info("异步消息发送失败:{}", JSON.toJSONString(throwable));
                         }
                     });
                 }

src/main/java/com/caimei365/tools/utils/SmsUtil.java

@@ -17,6 +17,9 @@ import java.nio.charset.StandardCharsets;
  * @date : 2021/6/17
  */
 public class SmsUtil {
+    /** key */
+    private static final String ACCOUNT = "account";
+    private static final String PASSWORD = "password";
     /** 通知短信 账户 */
     private static final String ACCOUNT_NOTICE = "N2532063";
     private static final String PASSWORD_NOTICE = "jzVvYmuP4D7f1b";
@@ -29,6 +32,8 @@ public class SmsUtil {
     /** 请求地址 */
     private static final String SMS_URL = "http://smssh1.253.com/msg/send/json";
 
+    private SmsUtil(){}
+
     /**
      * 发送短信
      *
@@ -40,16 +45,16 @@ public class SmsUtil {
         JSONObject params = new JSONObject();
         if (null != type && 2 == type) {
             // 验证码短信
-            params.put("account", ACCOUNT_YZM);
-            params.put("password", PASSWORD_YZM);
+            params.put(ACCOUNT, ACCOUNT_YZM);
+            params.put(PASSWORD, PASSWORD_YZM);
         } else if (null != type && 3 == type) {
             // 营销短信
-            params.put("account", ACCOUNT_ADS);
-            params.put("password", PASSWORD_ADS);
+            params.put(ACCOUNT, ACCOUNT_ADS);
+            params.put(PASSWORD, PASSWORD_ADS);
         } else {
             // 通知短信
-            params.put("account", ACCOUNT_NOTICE);
-            params.put("password", PASSWORD_NOTICE);
+            params.put(ACCOUNT, ACCOUNT_NOTICE);
+            params.put(PASSWORD, PASSWORD_NOTICE);
         }
         // 手机号
         params.put("phone", mobile);
@@ -59,7 +64,7 @@ public class SmsUtil {
         params.put("report", "true");
 
         String requestContent = params.toString();
-        URL url = null;
+        URL url;
         try {
             url = new URL(SMS_URL);
             HttpURLConnection connection = (HttpURLConnection) url.openConnection();
@@ -81,7 +86,7 @@ public class SmsUtil {
                 // 开始获取数据
                 BufferedReader br = new BufferedReader(
                         new InputStreamReader(connection.getInputStream(), StandardCharsets.UTF_8));
-                String line = null;
+                String line;
                 while ((line = br.readLine()) != null) {
                     sb.append(line);
                 }